jftsang / pypew

Ecclesiastical calendar and pew sheet generator
MIT License
0 stars 1 forks source link

Trinity XV breaks PyPew #30

Closed kroll-101 closed 1 year ago

kroll-101 commented 1 year ago

Trinity XV appears out of order alongside Trinity XXV in feast selection. image

Selecting Trinity XV in fact generates a pew sheet for Trinity XXV, including its anticipated date, (despite the header quoting XV). image

feasts.csv has correct readings / content for Trinity XV, it's just not being pulled through.

kroll-101 commented 1 year ago

The coeaster value in the the yaml file for this feast is incorrect. Checking what happens with a manual fix.

Iff this is the fault, would be worth knowing how the break happened (is there an issue in yaml conversion?) .

Worth writing a test to check coeaster / coadvent values are all unique and correctly calculated?