jfujita / videojs-http-source-selector

VideoJS plugin that leverages videojs-contrib-quality-levels plugin to offer manual user-select able level selection options for adaptive http streams.
MIT License
62 stars 49 forks source link

menu item selected style doesnt work #7

Closed Yahasana closed 5 years ago

msjh80311 commented 5 years ago

+1 When clicking on one of the quality menu list item, the source successfully changed. However, the selected list item doesn't show any style (ex, with background color or different text color from the un-selected ones) to recognize which is selected.

MichSimi commented 5 years ago

+1 not add .vjs-selected class to the .vjs-menu-item

leonklingele commented 5 years ago

This probably is because the item is not marked selectable: https://github.com/videojs/video.js/blob/4b325ea8f8188a5db76489243f7469ba8f7995ba/src/js/menu/menu-item.js#L111