search

jfuruness / bgpy_pkg

Simulates attack/defend scenarios in BGP
BSD 3-Clause "New" or "Revised" License
24 stars 7 forks source link

[website] Fields can be left blank when creating a roa and buttons will just silently fail #128

Open jfuruness opened 4 months ago

Arvonit commented 4 months ago

Fixed. ROAs now also give error toasts if fields aren't valid

jfuruness commented 4 months ago

Same comment I made on another ticket - is there a reason we don't just add a little red subtext that says the field is required (which seems to me to be common practice)? It feels weird to me to have a pop up in a different place, especially when if you leave all fields blank only one pop up shows up. Additionally, if you click add multiple times, you're going to get multiple pop ups for the same things.