search

jfusion / org.jfusion.jfusion

Universal integration bridge for joomla
25 stars 15 forks source link

Jfusion2.0 url parse fix #14

Closed markgawler closed 8 years ago

markgawler commented 8 years ago

I have tested these changes on my live site for over a month with no issues.

Remove popup code as phpBB3.1 no longer uses popup notifications and resolve issue with double slashes and invalid relative paths. These issues become worse when using sh404sef extension.

First change line 412: Three changes!

  1. Remove leading / to prevent double / between domain name and path, with sh404sef a ../../../ relative path can be generated, this needs removing, so strip out any slashes and dots at the start of the path [.\/]*
  2. To prevent modification of links to images for offsite avatars, etc. that include a domain name the any character sequence (.?) has been replaced with any character except colon ([^:]?)
  3. The match for end of path is now any sequence of at least one or singe quote, double quote or closing bracket (["\')]+)

Second Change 428: Remove popup code.

Third change line 723:

  1. Modify paten to remove a leading slash or dot to remove multiple slashes and dots [.\/]+ sh404sef was generating a ../../ sequence.

Fourth change 730: Remove popup code.

I hope this explains the changes.