search

jfversluis / FilePicker-Plugin-for-Xamarin-and-Windows

FilePicker Plugin for Xamarin and Windows
MIT License
157 stars 80 forks source link

[EXPERIMENTAL] Enable SourceLink #140

Closed jfversluis closed 5 years ago

jfversluis commented 5 years ago

Description of Change

Mainly testing this for another project, so don’t merge it, I will do it when ready :)

vividos commented 5 years ago

Interesting changes, I thought I already enabled SourceLink, but only followed a tutorial and couldn't test it thoroughly.

jfversluis commented 5 years ago

Ah did you now? What did you do to enable it?

vividos commented 5 years ago

My changes were in 82c2be0c4cda89dfb9536ea7b3ed794f6df097b4. I just tested with my app, FilePicker 2.1.18 and "Just My Code" ticked off, and I couldn't step into the PickFile() call.

jfversluis commented 5 years ago

Probably because of this: https://github.com/jfversluis/FilePicker-Plugin-for-Xamarin-and-Windows/pull/140/files#diff-650ae36e2fbf3ea95dd2be1cafb50bd7R66

That is why I couldn’t get it working with Xamarin.Forms.

Could you test the new beta one on NuGet?

jfversluis commented 5 years ago

@vividos did you get around to trying if sourcelink works with this one?

vividos commented 5 years ago

Sorry, not yet, but I try it out now.

vividos commented 5 years ago

I tried SourceLink by updating to the NuGet package 2.1.30-beta, disabling "Just my code" in VS and then stepping into a PickFile() call. Unfortunately it didn't work, I couldn't get into the FilePicker's code. I also checked the package with the NuGetPackageExplorer, and it has the Repository section, as mentioned in https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/sourcelink So I don't know what I'm doing wrong. Could you step into the FilePicker's code?

jfversluis commented 5 years ago

Hm maybe it doesn’t work yet for VS Windows with these types of projects. Leave it for now, we will look into it later :)

vividos commented 5 years ago

I'm sure I'm doing something wrong. You could compare with Xamarin.Essentials, I'm sure they got it working, but I also didn't debug into that NuGet.

jfversluis commented 5 years ago

Not necessarily, I think some changes are still needed in the debugger to fully support this. So maybe that hasn’t been implemented yet. I’m watching this closely for Xamarin.Forms so I will let you know when this should be good.

vividos commented 5 years ago

As I read that Xamarin Forms now supports SourceLink, we could merge this also, right?

jfversluis commented 5 years ago

Yep, just created a new pre-release version and used it with the latest VSMac preview bits and it worked!