Add settings/about screen

jfversluis / been-pwned

App that leverages the haveibeenpwned.com API by Troy Hunt. This app is available in the App Stores and is used in several of my talks as well as my book Xamarin.Forms Essentials.

MIT License

16 stars 3 forks source link

Add settings/about screen #31

Closed jfversluis closed 7 years ago

jfversluis commented 7 years ago

I think we need to add a settings (which also acts as a about screen). We can do it either as another tab, of maybe put a settings icon on the top navigation bar.

Things it should include:

Enable push
Enable hacker mode (easter egg?)
Disclaimer
OSS libraries used
...?

Depechie commented 7 years ago

Extra tab seems a bit overkill? Icon in nav bar maybe looks better?

Would also opt for trying to move the search bars up a few pixels. To have even margin between tab title and tab content with search bar in middle.

sthewissen commented 7 years ago

I would also add:

A link to this repo (so people can contribute)
Perhaps some about pages containing some text explaining things (could be copied from HIBP.com)

A settings icon somewhere top right seems like a good idea, but there are not really any tabs that lend itself for that more than the others. I would add it to each tab or give it it's own tab.

jfversluis commented 7 years ago

Started work on feature-settings-about branch

[ ] Enable push
[x] OSS libraries used
[x] A link to this repo (so people can contribute)
[x] HIBP FAQ

jfversluis commented 7 years ago

Done for now, extending this as we go