search

jfweemaes / ubiquity-xforms

Automatically exported from code.google.com/p/ubiquity-xforms
0 stars 0 forks source link

document.all is incorrectly used as a browser detection mechanism #576

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Some parts of the code test for the presence of document.all before choosing 
to execute an IE-specific path. In my tests of Safari 4, document.all 
actually exists as a property, leading to calls to attachEvent() rather than 
addEventListener being made in that browser (for example).

These problematic tests should be replaced by duck typing, i.e. specifically 
testing for the thing that is about to be used (addEventListener(), 
textContent, whatever).

Original issue reported on code.google.com by phil.boo...@gtempaccount.com on 1 Oct 2009 at 11:06

GoogleCodeExporter commented 8 years ago 
Proposed changes are awaiting review at r3026.

Original comment by phil.boo...@gtempaccount.com on 1 Oct 2009 at 12:46

GoogleCodeExporter commented 8 years ago 
Fix has been committed to trunk at r3032, updating status to Fixed.

Original comment by phil.boo...@gtempaccount.com on 2 Oct 2009 at 2:18