search

jgabaut / helapordo

A roguelike terminal game, using ncurses.
https://jgabaut.github.io/helapordo-docs
GNU General Public License v3.0
14 stars 0 forks source link

[FEATURE] KLS_PUSH() calls should pass types size with a pointer #55

Closed jgabaut closed 5 months ago

jgabaut commented 10 months ago

Describe the bug Calls to KLS_PUSH() macro are passing the Example type itself.

This is not recommended to do, since the call won't be correctly updated if you change the types and the typedef ends up having an incorrect size.

Using an expression pointer size is preferreable (eg. *example instead).

Additional context

See related koliseo issue: link

jgabaut commented 5 months ago

After some more reflection on this in here, I don't think this can be solved by just changing the used expression since koliseo really needs a straight type there.

A future version of koliseo might address this.

Closing for now.