search

jgabaut / helapordo

A roguelike terminal game, using ncurses.
https://jgabaut.github.io/helapordo-docs
GNU General Public License v3.0
15 stars 0 forks source link

[BUG] Game hang for left, right key press on saveslot pick #91

Closed khushal-banks closed 2 months ago

khushal-banks commented 2 months ago

Describe the bug After initial game start on screen that says, Select your save slot pressing invalid keys hangs the game. No keys work except sending a kill signal to the process by Ctrl-c

To Reproduce Steps to reproduce the behavior:

  1. ./helapordo -D
  2. Press enter to start
  3. Press enter again to start a new game
  4. Press left arrow key (or alternatively, press left/right key after pressing up/down keys)
  5. Yes, now enter or up/down arrow wouldn't work. (I also tried Esc or q or m nothing works)

Expected behavior Game should discard bad/invalid keys

Screenshots Comment if you want a screenshot. Didn't found it necessary.

Desktop (please complete the following information):

Additional context None

jgabaut commented 2 months ago

Is this for 1.4.7 ? You did not specify a version. If you caught this on devel branch, please say so.

khushal-banks commented 2 months ago

I tested it with master branch (main branch of this repository). I didn't specify version anywhere so it must be latest (not sure). I compiled the source and tested, so version must be latest right?

This issue is also present in devel branch. I tested devel branch to confirm it.

jgabaut commented 2 months ago

I didn't specify version anywhere so it must be latest

In top post it said "e.g. Latest" which is verbatim the template, without even dropping the "e.g.". Plus, if in the future I look at this issue, there's no clear indication of what "latest" means.

This issue is also present in devel branch. I tested devel branch to confirm it.

That's ok, I prefer for it to be on master so that it means the culprit is before the current developments (smaller, older surface area).

Found the culprit and fixed on devel: commit

This has been in the code ever since the first introduction of saveslot selection, back in 1.0.11.

khushal-banks commented 2 months ago

In top post it said "e.g. Latest"

Oh.. i thought i had to put the OS version. As this was asked under Desktop related heading. I will fix the version there.

jgabaut commented 2 months ago

In top post it said "e.g. Latest"

Oh.. i thought i had to put the OS version. As this was asked under Desktop related heading. I will fix the version there.

You are absolutely right, I should definitely clarify the issue template. Sorry!