search

jgabaut / helapordo

A roguelike terminal game, using ncurses.
https://jgabaut.github.io/helapordo-docs
GNU General Public License v3.0
14 stars 0 forks source link

[BUG] 1.4.8 fails build for raylib mockup #94

Closed jgabaut closed 3 months ago

jgabaut commented 4 months ago

Describe the bug After 1.4.8, the raylib mockup build fails building.

To Reproduce Steps to reproduce the behavior:

  1. Try building with ./configure --enable-raylib
  2. Build fails due to missing symbols expected from ncurses, which has never been included with raylib build and it should stay so.

Expected behavior Build succeeds because raylib build should not expect symbols from ncurses. Try to reproduce this from 1.4.7 and it should not happen.

I am fairly sure this is due to s4c-gui always including ncurses and such, so the code would need to make sure that module is not included and built when configuring for this kind of build.

Plus, this line should drop the switch statement since the logic now uses if else constructs.

jgabaut commented 3 months ago

This was fixed with 1.4.10, which corrects the key names and does some other tucking for the raylib build.