Closed jgabaut closed 4 months ago
As of 1.4.8, this check is used to avoid build failures when building with a ncurses library that does not support reset_color_pairs() extension:
1.4.8
ncurses
reset_color_pairs()
#ifndef reset_color_pairs
Which does not have the intended result at all, since the preprocessor can't be used for this kind of checks.
It may only check for a macro definition, and it seems ncurses does not provide one to identify the availability of this extension.
Thus, the only solution to me seems adding a new build conditional that handles the definition of our own macro to use in the #ifndef.
#ifndef
#ifndef HELAPORDO_SUPPORT_DEFAULT_BACKGROUND
The setting should probably be not enabled by default.
Version 1.4.9 added --enable-default-background option for ./configure, to define HELAPORDO_SUPPORT_DEFAULT_BACKGROUND at build time and enable this support.
1.4.9
--enable-default-background
./configure
HELAPORDO_SUPPORT_DEFAULT_BACKGROUND
As of
1.4.8
, this check is used to avoid build failures when building with ancurses
library that does not supportreset_color_pairs()
extension:Which does not have the intended result at all, since the preprocessor can't be used for this kind of checks.
It may only check for a macro definition, and it seems
ncurses
does not provide one to identify the availability of this extension.Thus, the only solution to me seems adding a new build conditional that handles the definition of our own macro to use in the
#ifndef
.The setting should probably be not enabled by default.