search

jgadsden / tin-whistle-tablature

MuseScore plugin to add tablature / finger diagrams to a tin whistle staff in a score
https://musescore.org/en/project/tin-whistle-tablature
GNU General Public License v2.0
24 stars 6 forks source link

Improved support for MuseScore 3 needed (and provided) #12

Closed DLLarson closed 5 years ago

DLLarson commented 5 years ago

Hi,

The current (circa June 2019) MuseScore version 3 of the tin-whistle-tablature plug-in is missing many great features compared to the MS v2 version.

I've taken this working on and fixed the MuseScore 3.x QML missing scripting feature required to properly select whistle keys and scales (i.e., property 'instrumentId').

In addition, I've modified the plug-in to place the tab images under the staff just like the 2.0 version provided.

Finally, I updated the example scores files and README.md images to reflect these improvements.

This all available in the following pull request:

https://github.com/jgadsden/tin-whistle-tablature/pull/11

Thanks for considering these changes!

Dale

DLLarson commented 5 years ago

The MuseScore 3 project has now merged the instrumentId fix for the 3.2 release.

-Dale

jgadsden commented 5 years ago

Hello Dale - excellent changes, good to see the plugin making much more sense. Sorry for the delay in approving the commit, it was a hectic weekend / Monday for me ... too much rail travel (I do not do air travel).

DLLarson commented 5 years ago

Sweet!

(I do not do air travel).

You computer security guys don't want the airplane to be hacked in the air? ;) A prudent choice. When I saw the OP-TEE reference I knew you are hard core.

Thanks! Dale

jgadsden commented 5 years ago

Most excellent work @DLLarson, thanks again for pull request #11 and closing this issue.

DLLarson commented 5 years ago

Thanks!

Dale

On Thu, Jun 27, 2019 at 1:21 PM Jon Gadsden notifications@github.com wrote:

Closed #12 https://github.com/jgadsden/tin-whistle-tablature/issues/12.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jgadsden/tin-whistle-tablature/issues/12?email_source=notifications&email_token=AABK2X33EZKQC6FZ7RW3CYLP4UALPA5CNFSM4H2XNB42YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSG7FQ5Q#event-2445170806, or mute the thread https://github.com/notifications/unsubscribe-auth/AABK2X4VLGEWZ5K5VI4AR7DP4UALPANCNFSM4H2XNB4Q .