Notes sometimes don't get tab added

[Merrit]

1. File -> New
2. Add Tin Whistle D
3. Done
4. Add notes: b e d b, b e d b
5. Add tin whistle tabs

Can see the first note in the second bar didn't get the tab added.

Not sure what notes / scenarios this happens, but this particular bit seems always reproducible.

OS: Fedora Linux 40 (KDE Plasma) Arch.: x86_64 MuseScore Studio version (64-bit): 4.3.2-241630832 revision: github-musescore-musescore-22b46f2

[jgadsden]

Hello @Merrit , thank you for raisig this issue - it is really good to have feedback on the Tin Whistle plugin

What we have here is the design feature where if a note is repeated then the tablature is not repeated. At the time it just seemed to be the convention when I was learning tin whistle. So the tablature is for each change of note

Having said all that, this is well worth a discussion topic and so I will create one for this issue #43

[jgadsden]

From the discussion in #43 , we should repeat the note's tab if :

• it is at the beginning of a bar
• or it is at the beginning of a line

@Merrit if you want to go ahead with changes then that would be great, otherwise I think I can look at this in a couple of weeks after Lisbon OWASP AppSec conference is over

[Merrit]

I am backed up on some KDE work, and other projects - but I will try to find some time shortly to look through the code. :)

[Merrit]

I took a look, though from what I can gather with MuseScore 4 they disabled the ability to use console.log, so I am not sure how they expect anyone to debug plugins. Perhaps I am just missing it.

[jgadsden]

File tin_whistle_tablature.qml line 328, section of code that is removing duplicate notes:

                  if (pitch === lastPitch) {
                     // don't add tab if parent note is same pitch as previous note
                     console.log("Skipped repeated parent note, pitches : " + pitch + ", " + lastPitch)
                  }