jgaeddert / liquid-dsp

digital signal processing library for software-defined radios
http://liquidsdr.org
MIT License
1.82k stars 426 forks source link

AGC functions in documentation aren't in code #106

Open DavidQrc opened 6 years ago

DavidQrc commented 6 years ago

Hi, I was wondering why the documentation mentions agc squelch functionality, but I don't see the squelch functions in the source code, and my code won't compile when trying to call the functions agc_crcfsquelch...

I'm using version 1.3.0.

jgaeddert commented 6 years ago

I pulled the squelch functionality out of the AGC in order to improve it, but haven't added it back in yet. Is this a critical function for your development? It wouldn't take long to add back in if so. The API will probably change as a result, though.

DavidQrc commented 6 years ago

It's not critical. I was just investigating it for possible use in an application I'm working on. I've actually developed a squelch function more specific to the application, so no hurry. I was mainly wondering if I was somehow out of sync and the functions were really there.

jgaeddert commented 6 years ago

Yeah, I'm the one who's out of sync =)

On Fri, Oct 13, 2017, at 02:48 PM, DavidQrc wrote:

It's not critical. I was just investigating it for possible use in an application I'm working on. I've actually developed a squelch function more specific to the application, so no hurry. I was mainly wondering if I was somehow out of sync and the functions were really there.> — You are receiving this because you commented. Reply to this email directly, view it on GitHub[1], or mute the thread[2].>

Links:

  1. https://github.com/jgaeddert/liquid-dsp/issues/106#issuecomment-336536949
  2. https://github.com/notifications/unsubscribe-auth/AAPcY82ag_xZjzoDudheyAp3YWEBlaUaks5sr7BvgaJpZM4P0nvH
DavidQrc commented 6 years ago

I see that you added the squelch functions back into AGC in this recent commit:

https://github.com/jgaeddert/liquid-dsp/commit/4f401231d098fb34a48eefb53ae2aad71ffb3118.

Thanks for the updated code!