search

jgaeddert / liquid-dsp

digital signal processing library for software-defined radios
http://liquidsdr.org
MIT License
1.89k stars 443 forks source link

Why was "resamp.c" removed? #154

Open brian-armstrong opened 5 years ago

brian-armstrong commented 5 years ago

Hi Joseph,

I've been merging your master into my devel branch, and I noticed that resamp.fixed.c seems to have replaced resamp.c https://github.com/jgaeddert/liquid-dsp/commit/33448b3948ca249c7812bd3492e5edc9332b8854#diff-6f96f867053ce404e0f2bd3156117448

I implemented a new block output mode for my resamp that my branch depends on, and unfortunately resamp.fixed.c doesn't implement this mode. I could fix it, but I'm curious what the tradeoffs are with resamp.c vs resamp.fixed.c. Is it sane to just swap resamp.c back in?

brian-armstrong commented 5 years ago

For reference, the change is https://github.com/jgaeddert/liquid-dsp/pull/28