search

jgaeddert / liquid-dsp

digital signal processing library for software-defined radios
http://liquidsdr.org
MIT License
1.82k stars 426 forks source link

Fix SONAME not set in shared library #335

Closed andreasbombe closed 9 months ago

andreasbombe commented 9 months ago

A SONAME was introduced to libliquid and used in installation file names however the shared library was always compiled with 'libliquid.so' as the SONAME rather than 'libliquid.so.1' as was probably intended.

Fix that and introduce a SOVERSION variable to the makefile so that it is defined in a single place only.

codecov[bot] commented 9 months ago

Codecov Report

Patch coverage has no change and project coverage change: +0.16% :tada:

Comparison is base (8bf87b6) 85.10% compared to head (29c404b) 85.26%. Report is 39 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #335 +/- ## ========================================== + Coverage 85.10% 85.26% +0.16% ========================================== Files 367 367 Lines 27280 27233 -47 ========================================== + Hits 23216 23221 +5 + Misses 4064 4012 -52 ``` [see 29 files with indirect coverage changes](https://app.codecov.io/gh/jgaeddert/liquid-dsp/pull/335/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joseph+D.+Gaeddert)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jgaeddert commented 9 months ago

thanks for this! I keep forgetting the proper SOVERSION