search

jgallen23 / grunt-inline-css

Grunt task for turning an html file with linked css to inline css. Great for emails.
MIT License
195 stars 33 forks source link

node.js v0.12 problem #21

Closed peterkracik closed 7 years ago

peterkracik commented 9 years ago

with a version v0.12 of node.js I've got this error: Fatal error: Cannot read property 'removeChild' of null

I havent found from which package it is from, just that it works OK on the version 0.10.3

NotBobTheBuilder commented 9 years ago

This happens within Automattic/juice, which added Node v0.12 support in juice v1.0.0. I think this repository is dead now judging by inactivity of owner, so I doubt this will get fixed.

NotBobTheBuilder commented 9 years ago

FWIW I have a working fork here. Not planning on deleting it, but I encourage you to fork it so you have control of your own dependency.

https://github.com/NotBobTheBuilder/grunt-inline-css

alexturpin commented 9 years ago

Thanks for the fork @NotBobTheBuilder . I've forked it into my org.

ghost commented 9 years ago

still doesnt work for me... I have the same error... any idea?

blacksun1 commented 7 years ago

Hi @hatto, @omarhab and @NotBobTheBuilder, I'm looking into this package now. If this is still of interest to you, please re-test and log another ticket. Current tests are working in both 0.10 and 0.12 as Juice has been upgrade to 3.0.1 so I'm closing this one.

Regards,