jgallen23 / grunt-inline-css

Grunt task for turning an html file with linked css to inline css. Great for emails.
MIT License
195 stars 33 forks source link

Just doesn't work for me. Any ideas? #4

Closed cmalven closed 11 years ago

cmalven commented 11 years ago

This is going to be a really vague issue, so I apologize in advance. The thing is, even the simplest possible test case fails for me: using in.html and file.css located in your example folder with an inlinecss task identical to the one provided in your README.

Thing is, I can tell that the task is running and it doesn't report any errors. Grunt reports:

Running "inlinecss:main" (inlinecss) task
File "out.html" created.

And the <style> block and <link> are properly removed from out.html, but there is no CSS inlined. I've also tried various other test cases using more custom code. No dice.

I have no idea how to even troubleshoot this further. Could I possibly be missing an npm dependency somewhere? Any help on tracking down the problem would be greatly appreciated, and if I can provide any more info I'll gladly do so.

cmalven commented 11 years ago

I figured it out. This was incredibly frustrating, but probably not anyones fault.

The path to my css file had a space in it. Removed the space and everything works fine. Ugh.

dannyprose commented 10 years ago

Just an additional note on this we ran into today: this issue is not limited to the relative path, but the system path as well. Nothing can have spaces.

alexluke commented 10 years ago

I proposed a fix for this in LearnBoost/juice#53