search

jgamble / Algorithm-Networksort

Release history of Algorithm-Networksort
https://metacpan.org/release/Algorithm-Networksort
Other
13 stars 4 forks source link

Final Documentation Push For 2.00 #19

Closed jgamble closed 8 years ago

jgamble commented 8 years ago

I think we're at a satisfactory point with the code. That leaves the documentation, which could stand improvement beyond the updated lists.

jgamble commented 8 years ago

Okay, it's done. Assuming I didn't miss anything. @Morwenn, @hoytech if there's anything I'm messing up in crediting you, please let me know.

By the way, I'm currently reserving the simple printing of the network ('print $nw;') to a grouped-style form. If that looks stupid (say, you think the formatted output should be the output and the grouped form should be via a method, let me know.

I have one item of my own -- any objection to shortening 'oddeventransposition' to something like 'oddeventrans' or 'oddeventrpos'?

Morwenn commented 8 years ago

Don't worry everything looks fine :)

I fear I can't help you for the design questions though; I still know next to nothing about Perl. I tend to try to fully spell out the variable, class and function names I use too, so I'll let @hoytech and you decide on what you think is best for oddeventransposition.

Anyway, it's good to see that the new release is ready.

hoytech commented 8 years ago

Docs look good, thanks!

I have no objections to renaming oddeventransposition, it is a bit of a mouthful.

jgamble commented 8 years ago

Okay, as of now, Algorithm::Networksort is up on CPAN!

Now to see what the testers think of it.

Thank you, everyone.