jgarci40 / battery-indicator

Automatically exported from code.google.com/p/battery-indicator
Other
0 stars 0 forks source link

Lockscreen Reenables after Restart #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Disable Lock Screen using BIP
2. Restart phone
3. After phone has fully booted, turn off the screen, then turn it back on.

What is the expected outcome? What happens instead?
After restarting the phone and turning off then back on the screen, I expect 
there to be no lock screen since I have disabled it using BIP. However every 
time after I restart my phone, the lockscreen is on again. I then have to open 
BIP and press Reenable, then Disable Lock Screen to turn it off. 

What branch (Free or Pro) and version (number) of the app are you using?
Pro 4.0.4

Which device are you using?
HTC Evo 4G

Which carrier are you using?
Sprint

Which version of Android are you using?
2.2

Please provide any additional information here:
I used to have an app that I believe was called "No Lock" that I used to 
disable my lockscreen before I found BIP. I uninstalled it after installing 
BIP. It used to keep the lockscreen off permanently, even after restarting the 
phone. With BIP though, I have to re-disable it each time. According to BIP, 
the lockscreen is still disabled, because the option says "Reenable 
Lockscreen." However, the lockscreen is already on. To disable it again, I have 
to press Reenable then Disable.

Original issue reported on code.google.com by mredmond...@gmail.com on 30 Sep 2011 at 6:41

GoogleCodeExporter commented 9 years ago
Hi.

Thanks for this report, but unfortunately I can't reproduce the issue.  On both 
of my test devices (Nexus One and MyTouch 3G) as well as on the emulator, the 
lock screen is still disabled after a restart.

First, note that it is normal to have to pass the security screen once before 
the disable takes effect.  This isn't necessarily the case on boot, but it 
might be, depending on your device.  So you might have to unlock once after a 
reboot, but then not bother going into BIP to toggle the re-enable/disable -- 
you might be good to go after unlocking once.  Just mentioning in case that's 
what's going on.

Assuming you really do have a case of the lock screen not being properly 
disabled after reboot, the only thing I can think of is that BIP is being 
started on boot before the lock screen system has finished booting.  Therefore, 
one possible solution would be to implement some sort of delay before disabling 
the lock screen on boot up.

So I guess I need two pieces of information in order to proceed:

1) Please confirm that it's not just that you need to unlock once after reboot, 
but that the lock screen truly doesn't get disabled at all after reboot.

2) Would you be willing to try out a test build of the proposed solution and 
let me know if it resolves the issue?  If so, I'll implement it and email it to 
you soon.

Original comment by andr...@darshancomputing.com on 26 Oct 2011 at 6:26

GoogleCodeExporter commented 9 years ago
Thanks for the reply!

I actually just switched to CyanogenMod 7.1, and that had an option in the 
settings to completely disable the lockscreen, which fixed my issue. However 
I'll turn off that setting and test out what you suggested. And yes, I'd be 
more than willing to try out a test build. 

Original comment by mredmond...@gmail.com on 26 Oct 2011 at 2:30

GoogleCodeExporter commented 9 years ago
Alright, I just tested it again several times, and it is still doing the same 
thing I described before, both on the stock Sense ROM and CM7. This what 
happened every single time:

I ensure that I have disabled lockscreen using BIP. I turn the screen on and 
off, and the lockscreen is indeed disabled. I then restart the phone. After 
restarting, the lockscreen shows up and the screen turns off. I wait a little 
bit to let the system completely finish loading everything. After a few minutes 
I turn the screen back on, unlock the lock screen, wait a short time, and turn 
the screen off. I immediately turn the screen back on, and the lockscreen is 
disabled, but if I turn the screen back off and then back on a little later, 
the lockscreen is back on and it stays on. The only way to again disable it is 
to open BIP and click Reenable Lockscreen then Disable Lockscreen. As I said in 
my OP, I have to do this again every time I restart in order to disable the 
lockscreen using BIP.
I don't have any security lock enabled on my phone

Original comment by mredmond...@gmail.com on 26 Oct 2011 at 6:16

GoogleCodeExporter commented 9 years ago
I don't know if it would help at all, but since CM7 is open source, perhaps you 
can look at what they use/do to permanently disable the lockscreen when the 
option under Settings > CyanogenMod Settings > Tablet Tweaks > Disable 
Lockscreen is selected. I don't know if the method they use requires root, but 
if it doesn't, it may be worth looking at as it completely and flawlessly 
disables the lockscreen  permanently until the option is turned off. The 
lockscreen doesn't even show up at all after a reboot.

Original comment by mredmond...@gmail.com on 26 Oct 2011 at 6:22

GoogleCodeExporter commented 9 years ago
"After a few minutes I turn the screen back on, unlock the lock screen, wait a 
short time, and turn the screen off. I immediately turn the screen back on, and 
the lockscreen is disabled, but if I turn the screen back off and then back on 
a little later, the lockscreen is back on and it stays on."

Huh, that's disconcerting -- I don't know why it would be disabled and then 
re-enable itself.  It slightly busts a hole in my theory of what might be 
happening.  I guess I'll just hope that it's because you're doing it so fast, 
the lock screen just hasn't come back yet.  I've made a test build based on my 
original theory; I'll send it to you momentarily and we'll see if it helps.

Original comment by andr...@darshancomputing.com on 29 Oct 2011 at 11:32

GoogleCodeExporter commented 9 years ago
Re: Comment 4 -- CyanogenMod, being a fork of the OS itself, can do things the 
easy way.  If the OS wants to not to have the lock screen, it can just turn it 
off internally.  Getting a user-land app to ask the OS not to show it is a 
different beast.  So while it's a good thought to check out the CM sources, it 
wouldn't help in this case.

Original comment by andr...@darshancomputing.com on 29 Oct 2011 at 11:36

GoogleCodeExporter commented 9 years ago
Ah, I see, that makes sense. I'll test out the solution you emailed me then.

So native/stock Android doesn't provide a way to turn off the lock screen then? 
How do you manage to disable it using BIP then?

Original comment by mredmond...@gmail.com on 30 Oct 2011 at 5:44

GoogleCodeExporter commented 9 years ago
It provides a way of saying, "Please don't show the lock screen."  CyanogenMod 
doesn't have to bother with that -- it can directly access the methods and data 
structures that that request is a wrapper around, which is more full-proof: it 
can literally just turn the lock screen off, so there's no way it'll show up.

Since my request, "Please don't show the lock screen" isn't working on your 
device when the request is made at boot-up, the hope is that by making the 
request again 10 seconds later, the system will comply with the second request.

Original comment by andr...@darshancomputing.com on 30 Oct 2011 at 6:40

GoogleCodeExporter commented 9 years ago
Sorry for the delay in getting back to you. I just finished testing the build 
you sent me through several different reboot scenarios, and it has worked 
perfectly and consistently in all of them. It appears your fix did the trick :)

Like you said, I still have to unlock the screen once after rebooting, but 
after that one initial unlock, it stays permanently unlocked.

Thanks so much for your help resolving this issue! Just let me know if you have 
any more questions or comments, or if you want a system log or anything. I 
really appreciate your support.

Original comment by mredmond...@gmail.com on 2 Nov 2011 at 5:20

GoogleCodeExporter commented 9 years ago
In the last few weeks I've had the same issue where screen lock intermittently 
turns itself back on on my verizon droid x. The only reason I purchased BIP was 
to disable the screen lock, now it comes back on several times a day. Been 
great for the year our so synced I purchased it

Original comment by dcthurma...@gmail.com on 6 Nov 2011 at 3:07

GoogleCodeExporter commented 9 years ago
Re: Comment 10

Does your issue seem to only happen immediately after restarting your device?  
If not (which sounds like the case) you should file a separate issue report and 
I'll see if I can help.

Original comment by andr...@darshancomputing.com on 8 Nov 2011 at 3:01

GoogleCodeExporter commented 9 years ago
I think this was fixed in November 2011, and I forgot to close it. For lock 
screen issues not involving reboot, see Issue 161.

Original comment by andr...@darshancomputing.com on 15 Jul 2012 at 9:23