search

jgarcia215 / CS471WorkflowsHomeworkAssignment

CS471WorkflowsHomeworkAssignment
0 stars 0 forks source link

Task 4 squash #8

Closed jgarcia215 closed 6 months ago

jgarcia215 commented 6 months ago

Closes #4

TBD_Add_Additional_PR_Details_or_Delete

scrumlinter[bot] commented 6 months ago

:thumbsup: Pull Request Description

:thumbsup: This pull request is referencing #4*

* the assumption is that #4 is a valid task or bug, but this is not currently checked by the ScrumLinter [bot]

:heavy_exclamation_mark: Pull Request Commits

Commit number Commit sha Message Feedback / Comments
1 3a8828c [task_4_squash] first partial commit for task #4 | :heavy_exclamation_mark: :link: This commit is referencing #4, but it should not link to any issues, as indicated in our preferred workflow. All commits pushed to the branch will be squashed before being integrated in the master branch, and the traceability :link: will be established in the squashed commit. There is nothing to do for this commit, but please keep this advice in mind for the future.
2 5bbb0e7 [task_4_squash] another partial commit for task #4 | :heavy_exclamation_mark: :link: This commit is referencing #4, but it should not link to any issues, as indicated in our preferred workflow. All commits pushed to the branch will be squashed before being integrated in the master branch, and the traceability :link: will be established in the squashed commit. There is nothing to do for this commit, but please keep this advice in mind for the future.
3 deb1d72 [task_4_squash] another partial commit for task four (oops, forgot the traceability) :thumbsup:
4 34f27d7 [task_4_squash] yet another partial commit for task 4 (without hashtag in front, no traceability will be established) :thumbsup:
5 e943094 [task_4_squash] last partial commit for task #4 | :heavy_exclamation_mark: :link: This commit is referencing #4, but it should not link to any issues, as indicated in our preferred workflow. All commits pushed to the branch will be squashed before being integrated in the master branch, and the traceability :link: will be established in the squashed commit. There is nothing to do for this commit, but please keep this advice in mind for the future.

:bulb: HINT: during squashing, use the commit message:

Closes #4 (#8)

Delete the extended description of the squashed commit.

:tv: See a quick demo video (i.e., the 60 seconds starting at 7:40 until 8:40) which illustrate the correct way to create the squash commit.

FAQ **Q: What type of data is analyzed by the [ScrumLinter [bot]](https://github.com/apps/scrumlinter)?** - The pull request description is verified to contain a link to an issue, but the issue is not checked if it's a valid task or bug - The pull request commits are analyzed to ensure they do not contain any traceability - The pull request `base` branch is verified to be `master` or `main` - When integrating the changes from pull request using squashing: - the commit message of the squashed commit is checked to ensure it contains two links: one to an issue (which may be a task or a bug) and one to the pull request - the extended description of the squashed commit is checked to ensure it is empty (i.e., it does not list the individual commits that are in the pull request) In other words, the [ScrumLinter [bot]](https://github.com/apps/scrumlinter) provides feedback about following the preferred workflow: - see the entire [playlist](https://www.youtube.com/playlist?list=PLCZRPp6GneWvN-0Ib7Gfb3E1YSOdEu1M6) or - see the 60 seconds starting at [7:40 until 8:40](https://youtu.be/ZhDxeRz2Ins?list=PLCZRPp6GneWvN-0Ib7Gfb3E1YSOdEu1M6&t=460) which illustrate the correct way to create the squash commit **Q: What type of data is NOT analyzed by the [ScrumLinter [bot]](https://github.com/apps/scrumlinter)?** All the data that is currently analyzed by the Scrum Linter report (linked in the `README.md` file), such as: - Product Backlog - Sprint Backlog - user stories - validity of tasks and bugs - milestones - etc. is not analyzed by the [ScrumLinter [bot]](https://github.com/apps/scrumlinter). **Q: What type of events trigger the [ScrumLinter [bot]](https://github.com/apps/scrumlinter) to generate a new comment in the pull request containing feedback?** - a new pull request is created - the description of an existing pull request is edited - commits are pushed to a branch where a pull request is still open
Beta Disclaimer [ScrumLinter [bot]](https://github.com/apps/scrumlinter) `v1.19.0` (see [Semantic Versioning](https://semver.org/)) is an experimental [GitHub Application](https://developer.github.com/apps/) that attempts to provide feedback regarding following the Scrum process augmented with software engineering best practices. This bot is still in **BETA**, and if you think the feedback provided is inaccurate please submit a bug report (i.e., email the instructor) and you can get extra credit.
#### Debug Information ``` github_event = pull_request payload_action = opened request_number = 6461 ```