search

jgarzik / cpuminer

CPU miner for bitcoin
Other
956 stars 2.35k forks source link

Pull request for Debian packaging #35

Closed smurfix closed 13 years ago

smurfix commented 13 years ago

This branch adds Debian packaging, including running as a dedicated user, and a couple of options to facilitate running in the background (--daemon and --pid-file).

jgarzik commented 13 years ago

gah, this pull request is a complete mess. A single pull request should not pull dozens of commits for all sorts of different features. Separate your pull requests out, one pull request per set of commits -- a "logical change."

smurfix commented 13 years ago

Hi,

jgarzik:

gah, this pull request is a complete mess. A single pull request should not pull dozens of commits for all sorts of different features. Separate your pull requests out, one pull request per set of commits -- a "logical change."

I can of course create separate branches for Debian packaging and the two new flags. However, I can't do a correct Debian package without the two flags, and the flag changes conflict anyway.

Is there anything in there you don't want to pull?

Reply to this email directly or view it on GitHub: https://github.com/jgarzik/cpuminer/pull/35#issuecomment-1525511

jgarzik commented 13 years ago

I won't even pretend I read through every commit, because the entire history is a mess... :) Adding options is not a problem, and adding Debian packaging to contrib/ or somewhere is not a problem. But all these commits need to be rebased sanely, and fix commits merged into the commits that needed fixing, etc.