search

jgarzik / python-bitcoinrpc

Python interface to bitcoin's JSON-RPC API
GNU Lesser General Public License v2.1
642 stars 307 forks source link

Allow authentication with empty password and also no authentication at all #12

Open devurandom opened 11 years ago

hno commented 11 years ago

Does not seem to allow authentication with empty username (only password). Line 71 " if self.__url.username is not None: " should check that both username and password is None.

But other than this it looks good to me. And also includes the Basic auth encoding fix in Pull #11.

devurandom commented 11 years ago

Does not seem to allow authentication with empty username (only password). Line 71 " if self.__url.username is not None: " should check that both username and password is None.

Is that actually possible/allowed and used anywhere? Authenticating with just a password?

luke-jr commented 9 years ago

Yes, I personally have used username-less (just a password) authenticated JSON-RPC.

reiven commented 9 years ago

@luke-jr looks like you need to fix some conflicts

luke-jr commented 9 years ago

This isn't my PR.