search

jgarzik / python-bitcoinrpc

Python interface to bitcoin's JSON-RPC API
GNU Lesser General Public License v2.1
644 stars 304 forks source link

License terms are not explicit #42

Closed cornwarecjp closed 8 years ago

cornwarecjp commented 9 years ago

The docstring in authproxy.py mentions that there is a "Previous copyright, from python-jsonrpc/jsonrpc/proxy.py", which refers to the "GNU Lesser General Public License as published by the Free Software Foundation; either version 2.1 of the License, or (at your option) any later version."

So, I suppose I can reasonably assume that python-bitcoinrpc is at least compatible with LGPL v2.1 or later. However, this still leaves some room for unclarity; I don't think that, the way it is now, I can be 100% certain that all of python-bitcoinrpc is available under LGPL v2.1 or later.

If it is the intention of all contributors to release their contributions under LGPL v2.1 or later (I hope this is the case), then please make it explicit.

Also, as a minor note: since the docstring says "You should have received a copy of the GNU Lesser General Public License along with this software", I think you should actually include a copy of the LGPL in the source tree.

koobs commented 9 years ago

Also, add LICENSE file to repository, and include it in PyPI sdist (using MANIFEST.in)

ghost commented 9 years ago

+1

maflcko commented 8 years ago

Looks like this was fixed by 8fcbaf0ee6ebb0c7930bb35790330f41b879197b

koobs commented 8 years ago

@MarcoFalke Confirmed, LICENSE is in the latest PyPI 0.3 source distribution (sdist)