search

jgauth / MMM-GoogleTasks

21 stars 26 forks source link

Set sorting #12

Open Clubjack1 opened 4 years ago

Clubjack1 commented 4 years ago

My Googletasks Module Shows the tasks in wrong order. Next tasks are at the end of the List.

gubbsjuk commented 4 years ago

Quick reply on the fly. Check out my branch that have added a simple sort.

Clubjack1 commented 4 years ago

Quick reply on the fly. Check out my branch that have added a simple sort.

You meant the children/parent sort? Can i copy that or what must i change for sort by date?

gubbsjuk commented 4 years ago

Its atleast children parent sorting. Cant remember if it sorts by date aswell. That should be fairly simple to implement.

I can look into it over the new years.

Clubjack1 commented 4 years ago

Its atleast children parent sorting. Cant remember if it sorts by date aswell. That should be fairly simple to implement.

I can look into it over the new years.

That would be really great. 👍🏽

tcginc2011 commented 4 years ago

Any word on this fix?

tcginc2011 commented 4 years ago

found fix sorry

Clubjack1 commented 4 years ago

Something New here?

gubbsjuk commented 4 years ago

Sorry all, havent gotten around to this yet... Hectic...

I imagine it should be rather easy though. Try looking into the built in sorting function in JS. I imagine that whould be the easiest and most efficent way of doing this.

Sorting parents first, and then adding the children in the order behind the respective parent.

Clubjack1 commented 4 years ago

No Problem.

I dont need sorting by parent andere children. I want to sort it by date.

gubbsjuk commented 4 years ago

@Clubjack1 Suddenly remebered this... botched something together quickly and updated my github repo. Currently not able to test it though, so use at your own risk... :')

esmoyer commented 4 years ago

Appreciate the work @gubbsjuk! I can't seem to get it to sort properly, still doesn't follow the due date it seems.

gubbsjuk commented 4 years ago

Sorry didn't specify this @esmoyer. You need to set a tag "ordering" in the config file to either 'dateAsc' or 'dateDesc'

ordering: "dateAsc" is the correct syntax I belive.

Did some minor testing and it seemed to work OK on my end. Let me know if you have further troubles.

esmoyer commented 4 years ago

No worries. When looking at the code i did note that but it still didn't seem to work. I'll do some more testing then. Thanks!

Sent from Android

From: gubbsjuk notifications@github.com Sent: Sunday, April 26, 2020 5:11 PM To: jgauth/MMM-GoogleTasks Cc: smoysauce; Mention Subject: Re: [jgauth/MMM-GoogleTasks] Set sorting (#12)

Sorry didn't specify this @esmoyer. You need to set a tag "ordering" in the config file to either 'dateAsc' or 'dateDesc'

ordering: "dateAsc" is the correct syntax I belive.

Did some minor testing and it seemed to work OK on my end. Let me know if you have further troubles.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.