jgauth / MMM-GoogleTasks

21 stars 26 forks source link

Does not work when listID is incorrect #14

Open lavolp3 opened 3 years ago

lavolp3 commented 3 years ago

When the listID is incorrect node_helper does not return a list. Then a function in the main code breaks with an error and this as well as all successive moduls are not created. The line creating the error is in MMM-GoogleTasks.js

var numTasks = Object.keys(this.tasks).length;

See https://github.com/lavolp3/MMM-AVStock/issues/46#issuecomment-720567680

lavolp3 commented 3 years ago

It is not difficult to fix it. I have worked on an own version of the module that is more sexy, and includes touch functions, need to check out how far it is.

You can also fix it locally but I will need to check in the next days how and where.

Let me get back to you in the next days. Remind me if not.

waldemarkotanski @.***> schrieb am Di., 1. Juni 2021, 23:23:

@lavolp3 https://github.com/lavolp3 have you figured out how to fix this issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jgauth/MMM-GoogleTasks/issues/14#issuecomment-852454735, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZHL3IYKXDBG43BSW3AJALTQVFUDANCNFSM4TIATAZQ .

waldemarkotanski commented 3 years ago

It is not difficult to fix it. I have worked on an own version of the module that is more sexy, and includes touch functions, need to check out how far it is. You can also fix it locally but I will need to check in the next days how and where. Let me get back to you in the next days. Remind me if not. waldemarkotanski @.***> schrieb am Di., 1. Juni 2021, 23:23: @lavolp3 https://github.com/lavolp3 have you figured out how to fix this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEZHL3IYKXDBG43BSW3AJALTQVFUDANCNFSM4TIATAZQ .

Yea, i've fixed it, but thank you anyways! Cant wait for your module!