search

jgayfer / pydest

Pydest is an asynchronous Destiny 2 API wrapper written in Python
MIT License
72 stars 22 forks source link

Hash values are converted to ints, when they should be unsigned ints #1

Closed jgayfer closed 7 years ago

jgayfer commented 7 years ago

Because of this, some hash values are entirely wrong, as they are being cast inappropriately.

jgayfer commented 7 years ago

Fixed by e4437d16373b4094792e4bb0a28c76ad830996e6

It turns out that it was actually the sqlite database that was converting the unsigned values to signed. Then the code was making queries of unsigned values against a signed database, so results were only returned half of the time. The new behaviour is to convert the unsigned values to signed when serializing the JSON.