The integer system works, and is common enough that it doesn't necessarily need to be changed.
But I think a case could be made for matching and working more directly with Bungie's membership type enum.
For example, something like:
Then in a pydest method, you could for example do destiny.api.search_destiny_player('steam', 'glass ships#9821') and parse the result as membership_types ['steam'] in the search_destiny_player() method
This is an amazing project by the way, a Python wrapper for the bungie API has long been needed. If there are any areas for contribution, please let me know, I'd be happy to help out however I can to keep this project healthy
The integer system works, and is common enough that it doesn't necessarily need to be changed.
But I think a case could be made for matching and working more directly with Bungie's membership type enum.
For example, something like:
Then in a pydest method, you could for example do
destiny.api.search_destiny_player('steam', 'glass ships#9821')
and parse the result asmembership_types ['steam']
in thesearch_destiny_player()
methodThis is an amazing project by the way, a Python wrapper for the bungie API has long been needed. If there are any areas for contribution, please let me know, I'd be happy to help out however I can to keep this project healthy