API calls for Clan command

jgayfer / pydest

Pydest is an asynchronous Destiny 2 API wrapper written in Python

MIT License

72 stars 22 forks source link

API calls for Clan command #7

Closed PhillypHenning closed 6 years ago

PhillypHenning commented 6 years ago

Adding new callers for the Destiny2 API

Context

The new clan command that is being added to Spirit requires access to additional Destiny2 API endpoints and manifest information.

How Has This Been Tested?

I have tested it locally with success but further testing needed.

Screenshots :

Successful output

Types of changes

New entry points into the Destiny2 API

Checklist:

[X] My code follows the code style of this project.

PhillypHenning commented 6 years ago

Hey @jgayfer I've updated the README

jgayfer commented 6 years ago

@PhillypHenning last but not least, it would be great if you could add some integration tests for the end points you added. You see can see how I have them setup in the tests folder. I'm not doing anything terribly fancy - just making a request with proper values to ensure that we aren't getting an error code.

It basically just serves as a nice way to ensure that we're playing nice with Bungie's API! :)

jgayfer commented 6 years ago

Awesome work! Really like the refactoring of the integrations tests :)