Add macOS/iOS support (via MoltenVK)

jgbit / vuda

VUDA is a header-only library based on Vulkan that provides a CUDA Runtime API interface for writing GPU-accelerated applications.

MIT License

865 stars 35 forks source link

Add macOS/iOS support (via MoltenVK) #7

Closed betajippity closed 5 years ago

betajippity commented 5 years ago

Hi! Thanks for the awesome work on creating VUDA! I was curious if I could get it to work on macOS/iOS via MoltenVK (Vulkan implemented on top of Metal).

These three commits add everything that is necessary to compile/run with VUDA on macOS/iOS. The main changes are:

Check for __APPLE__ preprocessor directive
Use a non-Linux-specific version of strerror_r on non-Linux Unix systems
Rename VUDA_LINUX to VUDA_UNIX. The macOS/iOS codepath is the same as the Linux codepath.
Some minor template fixes to compile using clang

Let me know if there any changes/fixes/cleanups to these commits that you would like.

jgbit commented 5 years ago

Hi there, thanks for taking interest in VUDA. It is good to see that someone made it work on macOS.

The changes seems to be in order. However, it would be better if the discrepancy between strerror_r on unix/linux could be solved in a manner that could avoid the #ifdefs. Perhaps similar to what is suggested here, http://www.club.cc.cmu.edu/~cmccabe/blog_strerror.html. Although, there might be some issues with the deprecated sys_errlist and sys_nerr on some systems.

betajippity commented 5 years ago

The solution you linked seems good; maybe the use of sys_errlist and sys_nerr won't be too much of an issue since as far as I know, Linux and macOS still provide those functions? The systems that typically don't provide implementations of sys_errlist/sys_nerr probably don't have Vulkan support either (Solaris, GNU/Hurd, etc). Or do you mean it might be more of a problem with throwing compiler warnings and whatnot?

If you're comfortable with using sys_errlist/sys_nerr, I can make the changes and submit a revised pull request.

jgbit commented 5 years ago

I think it is fair to rely on sys_errlist/sys_nerr for now, so please go ahead.