search

jgclark / vscode-todo-highlight

VSCode Extension to highlight TODOs etc.
MIT License
103 stars 21 forks source link

List highlighted annotations for open editors #21

Open warrentyy opened 3 years ago

warrentyy commented 3 years ago

Low priority, but might save some people from thinking the extension is broken or digging through settings like I did.

Right now, the List highlighted annotations only works when you have a folder open (and probably a workspace but I haven't tried that). When you are working on individual files in one or more editors, the command returns 0 results. In lieu of this, it might be beneficial for the response message to mention this caveat. Currently, it simply returns: "No results" even though the file I'm looking at clearly has highlights.

Hope that makes sense, aside from that minor thing, loving this extension!

alkatar21 commented 3 years ago

I think that is why I was just about to create an issue. I opened VSCode on a folder with scripts that have multiple TODOs and ran the List highlighted annotations command, but even though the files themselves have highlights, the command returns 0 results.

I am not sure I understand what is meant here, when the command works? Do I need a subfolder or am I misunderstanding and my case should work normally?

I am new to VSCode, but I am trying to get the TODO view of PyCharm back.

jgclark commented 3 years ago

I'm sorry but I don't know JS well, nor am I the original author of the plugin. (I am the maintainer of a new fork of this, as the original author abandoned it.). So I welcome PRs to improve the code or documentation on this point. (I have never used this feature, so I'm not sure quite what it should be doing.)

alkatar21 commented 3 years ago

I had a thinking error, it works for me now, but that has nothing to do with this issue. I will make an extra issue for this. But this would also be useful.

jgclark commented 3 years ago

I have updated the documentation to reflect this.

alkatar21 commented 3 years ago

The PR was not intended to close the issue, since the actual problem has not been fixed.

jgclark commented 3 years ago

Sorry, thought I was closing the PR.