search

jgellar / pcox

Penalized Cox regression models
1 stars 0 forks source link

Dependencies #22

Closed jgellar closed 7 years ago

jgellar commented 9 years ago

There are a few packages that pcox has as dependencies, for which we're only using 1 or 2 functions.

  1. pryr: the modify_call() function
  2. refund: I think there are only a couple accessory functions that we use? Things like safeDeparse().
  3. coxme: I don't think we are using this at all at the moment. The thought was that eventually we could use coxme() as the "fitter" instead of coxph() - it is designed for ML estimation, instead of the grid search that we are using. But last I checked, coxme() requires a "variance matrix", not a penalty matrix, which is a problem for us if the penalty matrix is not invertible.

It would be nice to eliminate these dependencies. coxme we could just remove for now, but for the others, I'm not sure what the etiquette is. Could I just copy the code for the 1 or 2 small functions that we need, and put them in pcox?

fabian-s commented 9 years ago

I think it's fine to copy small utilities as long as you give proper credit. at least that's how i would feel if somebody were to copy code of mine.

fabian-s commented 9 years ago

oops, wrong button....