jgero / roesena-app

Cross platform Web-App with user-created content and event manager
https://rösena.de/
0 stars 1 forks source link

major state refactoring #309

Closed jgero closed 3 years ago

jgero commented 3 years ago

To make some of the requested content and page storage features easier, a refactoring of the currently overly complicated different element states would be nice. There are way too many different state fragments in the application currently. It would probably be easier to have states for each type of content and then work with selectors or effects to load the desired content. I will think more about it and elaborate in further comments later.

jgero commented 3 years ago

The following diagram would be the simple version for the articles. Better managing of the state via the reducer will also fix the weird image disappearing from #306 and the overview reset of #307 would be fixed by timing better when the input gets cleared and active content is reset. The broken overview fly-in animation of #267 would probably be fixed by this as well. Implementing #308 would also get a lot easier.

rsn-state

jgero commented 3 years ago

Currently when opening a details page the element loading is triggered on init on the details page and the id is read from the id parameter from the router state. Is this right? What if at some point the event should be loaded from somewhere else without id parameter? Maybe add an optional id and "load from router" option to the single element loading actions to enable loading without router parameters.

jgero commented 3 years ago

This could help merge the different store modules.