search

jgeusebroek / docker-spotweb

A docker image running ubuntu/20.04 Linux and Spotweb
47 stars 27 forks source link

Select branch for spotweb #33

Open mesa57 opened 3 years ago

mesa57 commented 3 years ago

A request for an enhancement : It would be nice if there comes some parameter to determine the branch to checkout. Default should be master, but other branches should be possible (like develop). This would also greatly help our team in testing issue's and solutions.

jgeusebroek commented 3 years ago

Sorry, I was of the grid for a while. I could do this, no problem. But then you'd have to build a new image yourself for a different version then master / stable.

mesa57 commented 3 years ago

Master should be the default of course, so that would imply no change for current users. I understand that when a image is run, a new pull of spotweb is done ?

mesa57 commented 3 years ago

Ok, after reading some documentation I understand this is only possible at docker image build time. Maybe you could introduce a seperate tag for this purpose ? Last week 3 issues where reported which where all resolved in the develop branch. Users advised each other to switch to https://hub.docker.com/r/erikdevries/spotweb as that image uses the develop branch. I thought that this is not desirable.

Of course we will merge develop with master soon, but it is always lagging behind.

jgeusebroek commented 3 years ago

I could probably have 2 tags; master and develop.

mesa57 commented 3 years ago

Do you have any idea how https://hub.docker.com/r/erikdevries/spotweb implements that ?

jgeusebroek commented 3 years ago

As far as I can see it is building the master branch?

https://github.com/edv/docker-spotweb/blob/master/x86/Dockerfile

mesa57 commented 3 years ago

Hmmz, strange that users succesfully changed to that docker to solve an issue with IMDB which was solved in the spotweb/develop branch. Anyway : today we merged develop with master. I don't know if you have to update anything (tags?) for that. Thank you anyway, I will close the issue.

jgeusebroek commented 3 years ago

What's strange. Maybe they checked out a different build from within a running container? I've forced a new build, it should be done in a few minutes.

mesa57 commented 2 years ago

For you're reference : the erikdevries image does not specify a branch. Therefore git will pull the default branch which we set to develop Still it would be nice if you're dockerfile gives an opportunity to select develop or master.