search

jgeusebroek / docker-spotweb

A docker image running ubuntu/20.04 Linux and Spotweb
47 stars 27 forks source link

Using a spotweb database with no password prevents most of dbsettings.inc.php from being written #34

Closed JeremyCaron closed 2 years ago

JeremyCaron commented 3 years ago

Such an empty password value causes this line at the start of the block line 13 of entrypoint.sh to not execute the lines that would write out the env vars to the dbsettings.inc.php file. Only the port (when set as an env var on the docker command) is written.

if [[ -n "$SPOTWEB_DB_TYPE" && -n "$SPOTWEB_DB_HOST" && -n "$SPOTWEB_DB_NAME" && -n "$SPOTWEB_DB_USER" && -n "$SPOTWEB_DB_PASS" ]]; then

I had to set a dummy password on the docker command, and then edit the file in my mapped volume to set the pass to the empty string.

I'm the only user of my spotweb instance, and only use it on my local network, so I'm not concerned about the open DB in my particular use case.

JeremyCaron commented 2 years ago

ping @jgeusebroek - looks like you may have been away when I filed this so just a heads up

jgeusebroek commented 2 years ago

Sorry, I missed this. Thanks for the heads up. I will have a look asap.

jgeusebroek commented 2 years ago

Should be fixed with 1992ddf5b13efba338889ed4f115cb7874289633. Thanks for the patience :).