search

jgeusebroek / docker-spotweb

A docker image running ubuntu/20.04 Linux and Spotweb
47 stars 27 forks source link

Improved sed-comments when ran a second time #66

Closed Mattie112 closed 5 months ago

Mattie112 commented 5 months ago

I made a small mistake :) When running these commands a second time (e.d. restarting the container without pruning volumes) the commands would be executed again. No problem however except if your port starts with 80.

Listen 8090

Would become:

Listen 809990

And the same with the vhost. Any other port not starting with 80 would be fine :) I have updated the sed commands to match on the end of the line (for the Listen statement) and on the > for the vhost.

I didn't noticed this yesterday as it just worked the first time :) I was playing with it for a bit and at some point the container did not want to start so yeah this was the problem!

jgeusebroek commented 5 months ago

Thanks! Can you also add the configuration option to the readme?

Mattie112 commented 5 months ago

Ah yes that's a good one :)

jgeusebroek commented 5 months ago

Thanks! Merged!