jgfoster / Jade

Jade is an Alternative Development Environment (IDE) for GemStone/S that runs on Microsoft Windows
MIT License
6 stars 2 forks source link

2.2.7 - Invalid Comparand #34

Open feldti opened 6 years ago

feldti commented 6 years ago

When comparing two different versions of the same Monticello Package or even comparing with itselfs

feldti commented 6 years ago

In the Monticello Browser

feldti commented 6 years ago

I tried several versions: with 2.1.24 is also does not work, but with 2.1.23 it works

jgfoster commented 6 years ago

I've tried to reproduce this as follows: In Jade v2.2.8, using GS/S 3.4.2 seaside.extent0.dbf with nothing else loaded, select the first loaded package (Announcements.v3) in the first repository, and compare dkh.17 to dkh.18. I did not get an error. Can you reproduce this in seaside.extent0.dbf or does it require other things to be loaded? If you can reproduce this please provide an error log (with only the most recent error). Thanks.

feldti commented 5 years ago

I just started 2.2.10 against a 3.4.2 based database ... and I can not compare anything !

Here is a video showing the problem:

https://feldtmann.ddns.net/gemstone-public-stuff/jade-notcomparable.mp4.zip

I selected a random package and got that error

feldti commented 5 years ago

Under wine

feldti commented 5 years ago

Ok, I misunderstood the usage of the MonticelloBrowser. One has to select TWO items in the package list and then they are compared each other and this DOES work ! I thought, that the current loaded version is compared against the ONE selected package in the list.

jgfoster commented 5 years ago

If nothing else, we should properly handle the situation where a user selects only one version. Either (1) the menu command should be disabled, (2) a reasonable error should be reported, or (3) the comparison should be to the current image (as feldti expected).