There are some missing and outdated icons with last Dolphin version

jgfoster / Jade

Jade is an Alternative Development Environment (IDE) for GemStone/S that runs on Microsoft Windows

MIT License

6 stars 2 forks source link

There are some missing and outdated icons with last Dolphin version #39

Open brunobuzzi opened 5 years ago

brunobuzzi commented 5 years ago

For example: JadeAutocompletationConfigurationShell icon. JadeTranscript toolbar:

SUnit - old icon
Abort - old icon
Commit - old icon
Browser users - old icon
Monticello browser - old icon

brunobuzzi commented 5 years ago

Some icons has reference to Jade/icons folder. Do you want to continue to use this icons or we should update them with new icons contained in Dolphin image ?

jgfoster commented 5 years ago

I would very much like to use the new icons. Dolphin has made a big jump and we should tag along as best we can. I'm not sure how ambitious this issue should be, but at one time I thought of reducing our dependence on a large external DLL for the few icons we use (#98). I'm now not sure that the InternalIcon approach is best. Mostly, I'd like to figure out what is the "best practice" and then use it consistently. How should Windows apps handle icons? Help is appreciated!

brunobuzzi commented 5 years ago

It seems that @blairmcg has added the class TextTileIcon to handle icon. We should check that Jade icons are all instances of this class. The downside of using Dolphin icons is if they are deprecated (usually some of them are) from one version to another then we have to update Jade too. But i think that is not critical and the current Dolphin icon look awesome. I will further research regarding of issue jgfoster/Jade#18 in the meantime i will replace current icon with TextTileIcon instances.