jgfoster / Jade

Jade is an Alternative Development Environment (IDE) for GemStone/S that runs on Microsoft Windows
MIT License
5 stars 2 forks source link

MCPatchBrowser does not highlight code differences #40

Open brunobuzzi opened 5 years ago

brunobuzzi commented 5 years ago

It will be better to use Dolphin DiffBrowser ?

image

jgfoster commented 5 years ago

When Jade started out (nearly 20 years ago!) we needed to keep the Dolphin development tools out of the runtime (a commercial licensing issue). So, while Jade is clearly inspired by the Dolphin IDE, it does not use any of the Dolphin IDE code. With the open sourcing of Dolphin that all changes. Now it is reasonable to ask whether we should rewrite all these wonderful tools or if we can somehow just use them.

So, yes, it would be great to use the real Dolphin IDE code when building a GemStone IDE. (And doing so on a thorough scale would justify moving from 2.x to 3.x!) There is no (longer any) reason to rebuild what we can copy.

We will be doing our best work when we are removing more code than we are adding.

brunobuzzi commented 5 years ago

In the short term we can use Dolphin tools when is possible and this case is one of those. In the long term are you suggesting to somehow use Dolphin tools to access GemStone ? I mean for example subclassify Dolphin System Browser to display GemStone code. Maybe that is possible but it needs further research but it is a very interesting idea.:relaxed:

brunobuzzi commented 5 years ago

Dolphin will include a Diff browser for Smalltalk code so it can be used in Jade: https://github.com/dolphinsmalltalk/Dolphin/issues/726