search

jgfoster / Jade

Jade is an Alternative Development Environment (IDE) for GemStone/S that runs on Microsoft Windows
MIT License
5 stars 2 forks source link

MCRepositoryBrowser "Save as Topaz File-in" is broken #46

Open brunobuzzi opened 4 years ago

brunobuzzi commented 4 years ago

Here is the stack: 21/01/2020 17:14:48: 'Primitive failed: Se pasó un parámetro no válido a un servicio o función como segundo argumento.' ByteArray(Object)>>primitiveFailed: ByteArray(Object)>>_primitiveError:at:put: ByteArray(Object)>>basicAt:put: FileStream>>primitiveBasicNextPut: FileStream>>basicNextPut: ByteArray(SequenceableCollection)>>encodeOn:put: FileStream>>primitiveNextPut: FileStream>>nextPut: Utf8String(String)>>appendToStream: FileStream>>nextPutAll: MCRepositoryBrowser>>saveAsTopazFileIn

brunobuzzi commented 4 years ago

Modifying the FileStream (https://github.com/jgfoster/Jade/blob/master/sources/MCRepositoryBrowser.cls#L235) to be text: true it seem that fix the issue but it need more testing in order to do a Pull Request.

jgfoster commented 3 years ago

I believe that the difference between text and binary is that with text Windows will add a CR before every LF output. I think that a Topaz File-in would not expect to have those extra characters (though they might not hurt; not sure). But my inclination would be to leave the text just the way GemStone expects. Of course, it would be helpful to avoid the walkback, and clearly something is wrong. Do you have a simple Monticello repository that reproduces the problem?

feldti commented 2 years ago

This is still not working. It happens with all repositories I trie Jade.ERRORS.txt d