search

jghaanstra / com.xiaomi-miio

Homey app to control Mi Home devices that implement the miIO protocol and Xiaomi gateway child devices
GNU General Public License v3.0
456 stars 85 forks source link

fix set_led_level arguments #275

Closed makleso6 closed 2 months ago

makleso6 commented 2 months ago

Fixing set led level command with int args 0 - on 2 -off

also fix temp on zhimi.airfresh.va2

jghaanstra commented 2 months ago

Thanx, did you test the changes related to the LED? According to the unofficial docs it acceppts values 0, 30 and 100 but this documentation is wrong sometime.

https://home.miot-spec.com/spec/zhimi.airfresh.va2

I wont be merging this PR as I already made the required changes related to the temperature locally but I can manually integrate any working settings for the LED as well when I know this change actually works.

makleso6 commented 2 months ago

yes I test it locally

2024-09-11 17 25 53 2024-09-11 17 24 50

makleso6 commented 2 months ago

accepted values 0, 30 and 100 via miot accepted values 0, 1, 2 via miio

jghaanstra commented 2 months ago

Roger. I'll update my code locally and will push it with the next release.