jghibiki / Doc

Crowd sourced music player. Request songs in client plays them on server, great for groups. Uses embedded youtube videos as music background
MIT License
5 stars 2 forks source link

Explicitly use URL posted in search bar #60

Open EricWM612 opened 4 years ago

EricWM612 commented 4 years ago

Most of the time, posting a URL or video ID into Doc search (or YouTube search) will only find that video. However, some videos will find other results when the link or ID is searched - this being a good example. If Doc were to try the query as a URL or video ID and give that as the first option in the search results, that would make queuing certain videos much easier.

jghibiki commented 4 years ago

The biggest problem i could see with this is that it would require two queries instead of one, and that would double the number of requests per day, which on a busy day might push too close to the api rate limit for comfort.

EricWM612 commented 4 years ago

Very true, is there any way to check if it's a valid video URL or ID before sending the request? Then it would only use a second request on the off-chance that someone uses that feature.

However, this is a bit of a stretch for a feature request in the first place. If it doesn't happen, it doesn't happen.

jghibiki commented 4 years ago

the url bit might be doable, but checking for a valid video id might be more difficult.