search

jgi-kbase / IDMappingService

Service for mapping data IDs between namespaces.
MIT License
0 stars 3 forks source link

Bump pymongo to 3.8.0 to fix auth issues #124

Closed MrCreosote closed 4 years ago

MrCreosote commented 4 years ago

See https://api.mongodb.com/python/current/changelog.html#changes-in-version-3-7-1

Since KBase is currently on MongoDB 3.6 with MMAPv1, updating to pymongo 3.9.0 is not safe without further changes. Ideally we update to WiredTiger soon as MMAPv1 is deprecated in Mongo 4.0 and removed in 4.2. See https://api.mongodb.com/python/current/changelog.html#changes-in-version-3-9-0

Alternatively we can add a config option to turn off retryable writes if we need to upgrade to 3.9.0 and WiredTiger isn't deployed yet.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 270

Totals Coverage Status
Change from base Build 267: 0.0%
Covered Lines: 1153
Relevant Lines: 1184
💛 - Coveralls
MrCreosote commented 4 years ago

Basically trivial and @bio-boris is groovy with it so merging.