Create docker-publish.yml

jgi-kbase / IDMappingService

Service for mapping data IDs between namespaces.

MIT License

0 stars 2 forks source link

Create docker-publish.yml #130

Closed bio-boris closed 4 weeks ago

bio-boris commented 1 month ago

Lets update this to the behavior that we want

Xiangs18 commented 1 month ago

so secrets.GHCR_USERNAME and secrets.GHCR_TOKEN are not setup in iji-kbase and that's why we use this instead?

MrCreosote commented 1 month ago

A couple questions

It seems like this is building on merge only - it is possible to set things up to build on PR like the other repos?
How would we do release builds like https://github.com/kbase/auth2/blob/develop/.github/workflows/release-main.yml

bio-boris commented 4 weeks ago

Sorry, I missed these questions. I will look into it

Xiangs18 commented 4 weeks ago

so secrets.GHCR_USERNAME and secrets.GHCR_TOKEN are not setup in iji-kbase and that's why we use this instead?

If that's the case, why cannot we just set thing up in iji-kbase?

bio-boris commented 4 weeks ago

There are already tokens available and it is less tokens for us to maintain. Also, I would like to transition to the same docker images that the rest of the github actions community uses instead of maintaining our own custom ones.

bio-boris commented 3 weeks ago

Sorry @Xiangs18 I should have deleted this PR instead of merging it!