SCT-1251 Add gunicorn app

jgi-kbase / IDMappingService

Service for mapping data IDs between namespaces.

MIT License

0 stars 2 forks source link

SCT-1251 Add gunicorn app #98

Closed MrCreosote closed 5 years ago

jayrbolton commented 5 years ago

why not put that in src/jgikbase/idmapping? otherwise looks good

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 208

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.05%

Totals
Change from base Build 207:	0.0%
Covered Lines:	1037
Relevant Lines:	1091

💛 - Coveralls

MrCreosote commented 5 years ago

I actually just copied how you set up the caching service where the app was in the root. Do you think that's not a good idea?

See https://github.com/kbase/CachingService/blob/master/app.py

jayrbolton commented 5 years ago

For your repo, it might be more consistent, and is slightly less prone to namespace conflict In my repo, I wasn't concerned with namespace conflicts and didn't have any problems. I just put it in the root out of simplicity/laziness. I might nest things better in that repo soon