jgibbon / Talefish

Talefish is a simple directory based audio book player for SailfishOS
GNU General Public License v2.0
22 stars 10 forks source link

Translated into Spanish #1

Closed ghost closed 7 years ago

jgibbon commented 7 years ago

Awesome, thank you so much!

Two small notes I hope you can address before I integrate your changes:

Again, thank you!

ghost commented 7 years ago

HI velox

jgibbon commented 7 years ago

Hi, no problem, we all have to start somewhere. The TS-Tag is exactly right.

For the numerus it has do be:

<translation>
<numerusform>[output if the placeholder %1 inside is 1]</numerusform>
<numerusform>[output if the placeholder %1 inside is bigger than 1]</numerusform>
</translation>

You currently have:

<translation>
Click en el archivo para abrirlo o aceptar el diálogo para abrir %1 fichero(s)
<numerusform></numerusform>
Click en el archivo para abrirlo o aceptar el diálogo para abrir %1 fichero(s)</numerusform></translation>

It's almost right, but the texts have to be between <numerusform> and </numerusform>, for example (this will be horribly wrong spanish, my apologies):

<translation>
<numerusform>Click en el archivo para abrirlo o aceptar el diálogo para abrir una fichero</numerusform>
<numerusform>Click en el archivo para abrirlo o aceptar el diálogo para abrir %1 ficheros</numerusform>
</translation>

edit: messed up a bit myself there…

ghost commented 7 years ago

ok i will fix it right now , i am confused following your the german translation example. en first line.

jgibbon commented 7 years ago

I'll merge the pull request and try to fix the rest after it – you'll see what was changed then. Thanks, again, for your work!

(If you need to edit some translations, you can then edit the file with qt linguist instead of a text editor – it takes care of all that XML syntax stuff.)

jgibbon commented 7 years ago

I've fixed the other stuff at https://github.com/jgibbon/Talefish/commit/4cd0e907911198023e276670af8934635c409497

jgibbon commented 7 years ago

Oh, by the way, there are new strings available for translation. I've added those in the Talefish-es.ts in https://github.com/jgibbon/Talefish/commit/707857446ed449774f3d24e009c94ea21e592b8e :)