search

jgibbon / Talefish

Talefish is a simple directory based audio book player for SailfishOS
GNU General Public License v2.0
22 stars 10 forks source link

playback speed not always set #33

Closed thigg closed 3 years ago

thigg commented 3 years ago
  1. Set playback speed != 1
  2. audio plays faster.
  3. wait until track changes IS: after track change, playback speed jumps back to 1 SHOULD: keep the set playback speed

and

  1. Have playback speed != 1
  2. Close app
  3. start app
  4. start audio IS: playback speed back to 1 SHOULD: keep the set playback speed

Background is that the QtMediaPlayer of Sailfish gets pitch compensation when playback speed is changed: https://forum.sailfishos.org/t/no-pitch-compensation-when-playing-audio-with-playbackrate-1/

jgibbon commented 3 years ago

Thank you for investing your time to not only find and fix an issue here but to enhance that behaviour for (almost) all applications! Very much appreciated!

jgibbon commented 3 years ago

The current mer-5.6 branch of qtmultimedia including your patch (and apparently another small fix for it) is really great. Finally, the speed setting in Talefish makes sense!

I hope to find the time to fix this issue, at least for a whole lot of different use cases (the bug materializes a bit differently depending on when and how a file is loaded) next weekend. Release may take a bit longer.

cheers!

thigg commented 3 years ago

Keep me updated, podqast has the same problems. But I gonna do some refactorings before I fix this.

thigg commented 3 years ago

https://forum.sailfishos.org/t/qml-mediaplayer-playbackrate-not-wired-up-correctly/6165

opened bug report

jgibbon commented 3 years ago

Workaround is working reasonably well, hopefully for all use cases, released with 0.7-1 (on openrepos for now). Thanks for all your work!