Not respecting previous windows position and size

jgierer12 / pocket-casts-linux

⚠️ Currently not maintained ⚠️ - Electron wrapper around the Pocket Casts web app with support for MPRIS (media controls)

MIT License

11 stars 4 forks source link

Not respecting previous windows position and size #3

Closed evertonstz closed 5 years ago

evertonstz commented 5 years ago

Hey, I'm on GNOME 3.30.2, on Manjaro, the app won't previous windows after closed, doesn't matter the sizer or position on the screen it was, if you close the app window and open it again the app will be opened maximized.

jgierer12 commented 5 years ago

Could you try the AppImage linked in #4 (if you previously installed with pacman, click "No" when asked about system integration)?

Persisting the window state was something I planned to do but never really got around to, but it was really easy to implement and works flawlessly on my machine (also GNOME 3.30.2 on Manjaro :raised_hands: ).

What's a bit weird is that on your machine, the window opens maximized, which it shouldn't based on the default options. Should this still happen with the PR's AppImage, please send me a screenshot of your GNOME Settings > Devices > Displays, as well as GNOME Tweaks > Windows to help me investigate further.

evertonstz commented 5 years ago

Here's the behavior of this build on my system (nice to see firefox send getting used, it's a good service):

first launch: opens maximixed like the pacman version, opening speed is normal. I changed the size, moved it around and closed the app;
second launch: the window state persists and the splash screen will launch right with the size and position I left in the first run, but it'll take like 60 seconds for the app to fully load and go past the splash screen;

Strangely enough, I went and tried the pacman version I had installed in my system, and it's also not loading fast, since I did build it from AUR, I went and checked If I had uninstalled any dependecy, and they're all there. I can ping "play.pocketcasts.com" fine, so it seems to be related to my system. Strangely enough I didn't pushed any update since 2 days ago, and the appimage shouldn't care. I'm investigating, I've got this error msg... The issue with the screen is solved in the appimage, tho.

jgierer12 commented 5 years ago

Huh, that error is exactly what I thought I had fixed with this:

https://github.com/jgierer12/pocket-casts-linux/blob/61ad837a9ebc06c450da9dbe5a1780ab8e11a390/src/index.js#L25

I'll need to investigate why it's still occurring.

evertonstz commented 5 years ago

Huh, that error is exactly what I thought I had fixed with this:

pocket-casts-linux/src/index.js

Line 25 in 61ad837 const windowStateObj = JSON.parse(JSON.stringify(windowState));

I'll need to investigate why it's still occurring.

If you wish I can open another issue so you can close this one as apparently you fixed it. This error seems to be erratic, as it did not happened today, I'm using the app fine here. Strange.

jgierer12 commented 5 years ago

No, I am pretty sure that is a regression issue directly caused by #4, so I will only merge that once this issue is fixed, and continue discussion about this bug in #4 too.

evertonstz commented 5 years ago

No, I am pretty sure that is a regression issue directly caused by #4, so I will only merge that once this issue is fixed, and continue discussion about this bug in #4 too.

Ok, I'm always available if you need any testing.