search

jgieseler / solarmach

Python package of the multi-spacecraft longitudinal configuration plotter Solar-MACH
https://solarmach.readthedocs.io
BSD 3-Clause "New" or "Revised" License
26 stars 6 forks source link

Unpin matplotlib version in requirements #57

Closed nabobalis closed 1 month ago

nabobalis commented 1 month ago

Is there a need to pin MPL to one specific version?

jgieseler commented 1 month ago

Nothing serious. With one matplotlib update, the legend and annotation started to be misaligned and partly off the figure. That's why I pinned it to a previous working version, and haven't found the time to update the code to work with a recent version.

nabobalis commented 1 month ago

MPL does love to shift things around. The sunpy figure tests always have to be updated due to those issues.

jgieseler commented 1 month ago

My "problem" is that most solarmach users use the web version and/or don't update their packages if not explicitly needed, so no one complained so far. 😅

nabobalis commented 1 month ago

For context (which I did not provide at all), we are trying to construct a virtual environment with solarmach and a few other packages which have a higher min version of MPL. So we are hitting that.

jgieseler commented 1 month ago

Yeah, I was guessing something like this. Unfortunately my computer broke on Wednesday, so I'm a bit handicapped right now. Do you have a deadline for that project (like a summer school)?

nabobalis commented 1 month ago

It is no rush, we can increase the version of MPL in the env. We have like two plots and running some other solarmach functions, so at worst, some of the figures look different. It won't be a problem, so no need to work on this with any urgency.

jgieseler commented 1 month ago

Fixed with https://github.com/jgieseler/solarmach/releases/tag/v0.4.0

nabobalis commented 1 month ago

Thank you!