jgieseler / solo-epd-loader

Data loader (and downloader) for Solar Orbiter/EPD energetic charged particle sensors EPT, HET, and STEP. Supports level 2 and low latency data provided by ESA's Solar Orbiter Archive.
BSD 3-Clause "New" or "Revised" License
15 stars 2 forks source link

Obtain FILLVAL dynamically #7

Closed jgieseler closed 1 year ago

jgieseler commented 2 years ago

CDF FILLVAL right now hard-coded, obtain it dynamically from the CDF. [already in progress]

jgieseler commented 2 years ago

With #10 internally changed to sunpy.io.cdf.read_cdf() to read cdf files. This function will handle FILLVAL in the near future (cf. https://github.com/sunpy/sunpy/issues/5908). Will solve issue for _read_epd_cdf().

_read_step_cdf() still needs to be done!

jgieseler commented 2 years ago

_read_step_cdf() still needs to be done!

Solved with https://github.com/jgieseler/solo-epd-loader/commit/919cab231c76ed5bf3b2bacb5e0b162ef9eaf55b

jgieseler commented 1 year ago

With #10 internally changed to sunpy.io.cdf.read_cdf() to read cdf files. This function will handle FILLVAL in the near future (cf. sunpy/sunpy#5908). Will solve issue for _read_epd_cdf().

_read_step_cdf() still needs to be done!

With https://github.com/sunpy/sunpy/pull/5956 this should now be included in sunpy. Adjust code resp. verify!